-
Notifications
You must be signed in to change notification settings - Fork 4
✨: create HasArrayNamepace #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9318276
to
7ec8d29
Compare
Also, do we want to call it HasNamespace? |
7ec8d29
to
aaebe45
Compare
From the typing spec:
So I suppose |
aaebe45
to
151ea4b
Compare
83637a4
to
b6e28a6
Compare
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
b6e28a6
to
53732c8
Compare
FYI I'm a fan of squash merges, so totally feel free to do that here. |
I think I like the sound of |
SGTM. Done ✅ |
53732c8
to
7c5958f
Compare
e594225
to
d0a03c5
Compare
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
d0a03c5
to
c92ca8c
Compare
Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com> Co-authored-by: Lucas Colley <lucas.colley8@gmail.com> Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
c92ca8c
to
b8e497b
Compare
@jorenham addressing #17 (comment) dismissed your review. |
Thanks @nstarman @lucascolley :) |
Requires #12